From ea8cf5b3d71d79bfe8e3b6e9843f5e60dde2289a Mon Sep 17 00:00:00 2001 From: Bram Prieshof Date: Sun, 19 Nov 2023 23:02:32 +0100 Subject: [PATCH] DistroInventory: fixed Variable type in loops Varable in a loop can't be a local type Fixed not cleaning up type variable --- DistroInventory.sh | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/DistroInventory.sh b/DistroInventory.sh index cc025e8..ee9a32b 100644 --- a/DistroInventory.sh +++ b/DistroInventory.sh @@ -24,22 +24,24 @@ echo "Type,ID,Name,Status,Distro,Version" | tee $InventoryFile if $CheckVM; then TYPE=CT; for ID in $(pct list | tail -n+2 | awk '{print $1}'); do - local STATUS=$(pct status $ID |sed 's/status: //') - local NAME=$(pct config $ID | grep hostname |sed 's/hostname: //') - if [ $STATUS == "running" ]; then local OSRELEASE=$(pct exec $ID -- cat /etc/os-release);fi + STATUS=$(pct status $ID |sed 's/status: //') + NAME=$(pct config $ID | grep hostname |sed 's/hostname: //') + if [ $STATUS == "running" ]; then OSRELEASE=$(pct exec $ID -- cat /etc/os-release);fi ParseOSRelease unset OSRELEASE TYPE ID NAME STATUS DISTRO VERSION done + unset TYPE fi #VM Updates if $CheckCT; then TYPE=VM; for ID in $(qm list | tail -n+2 | awk '{print $1}'); do - local STATUS=$(qm status $ID |sed 's/status: //') - local NAME=$(qm config $ID | grep name |sed 's/name: //') - if [ $STATUS == "running" ]; then local OSRELEASE=$(qm guest exec 2002 -- cat /etc/os-release |jq -r '.["out-data"]') + STATUS=$(qm status $ID |sed 's/status: //') + NAME=$(qm config $ID | grep name |sed 's/name: //') + if [ $STATUS == "running" ]; then OSRELEASE=$(qm guest exec 2002 -- cat /etc/os-release |jq -r '.["out-data"]') ParseOSRelease unset OSRELEASE TYPE ID NAME STATUS DISTRO VERSION done + unset TYPE fi